Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$: Revert code changes in #4293 #4323

Merged
merged 2 commits into from
Mar 3, 2024
Merged

$: Revert code changes in #4293 #4323

merged 2 commits into from
Mar 3, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Mar 3, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr reverts the code changes in #4293 since they are no longer needed due to #4314.

Test plan

All builds are green.

Closing issues

...

@github-actions github-actions bot added the RzCore label Mar 3, 2024
@wargio wargio added this to the 0.7.1 milestone Mar 3, 2024
@kazarmy kazarmy merged commit 573aee5 into rizinorg:dev Mar 3, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@XVilka XVilka Awaiting requested review from XVilka XVilka is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
RzCore
Projects
None yet
Milestone
0.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kazarmy @wargio